Better autofocus, to make it work on mobile somehow #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing! I tried both the current implementation as well as this one and the behavior appears to be the same - the field gets focused and receives the colored border, but as you mentioned, the keyboard does not appear due to security restrictions. Is the field not getting focused for you at all with just the |
|
Yes the field wasn't getting any focus at all, but today i tried to reproduce this, and eventually nothing happening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whats the point
As mentioned in issue #208,
autofocusattribute on search bar do not works on mobile devices. This is due to security restrictions of Android/IOS devices. Keyboard cant be toggled without any kind of user interaction.Here's what people from react-select who have encountered the same problem say about it
I don't think there is any workaround in this case, to make this functionality works.
But this PR, adding border animation on search bar to make them works like in desktop version. Without this change, user can`t even figure out, that autofocus flag is enabled, because borders are blurred.